Clearer points in favour of macro mixing #2970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
approved these changes
Feb 14, 2024
Member
There was a problem hiding this comment.
I was surprised to see the phrasing "Experimental" in the old doc. The only caveat there is if the macro implementation method was compiled by Scala 3 then you can't use things like quasiquotes or eval, but if the macro method is in a separate 2.13 compiled module then this is no issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the scala 3 migration docs to emphasis the benefits of macro mixing rather than indicating that it's experimental.
--
The background is as follows:
We are trying to update our code gradually to scala 3. In one case we have a large multi project build which produces many semi-related jar files for deployment into AWS lambda.
I am trying to update this module by module, but I quickly hit an issue where play-json had scala 2.13 and 3 versions.
Normally I would just force version 3 and use
-Ytasty-reader, however in this case because it's a macro library, the modules remaining on scala 2.13 didn't compile any more.I proposed adding macro mixing to the library, but this was pushed back on the basis that it wasn't necessary and is not promoted by the docs. See the issue below:
playframework/play-json#954
I think this is not really accurate (is it?) and I think this is going to be a blocker for all of our larger repos in our company, and possibly other organisations.